Re: Add new COPY option REJECT_LIMIT - Mailing list pgsql-hackers

From Kirill Reshke
Subject Re: Add new COPY option REJECT_LIMIT
Date
Msg-id CALdSSPjgKyFRnqPV2BfUDDb1xx4CPO4sLZKbEKFLf5FOMBkpQQ@mail.gmail.com
Whole thread Raw
In response to Re: Add new COPY option REJECT_LIMIT  (torikoshia <torikoshia@oss.nttdata.com>)
Responses Re: Add new COPY option REJECT_LIMIT
List pgsql-hackers
Hi! Nice feature.

Few comments:

> +      When a positive integer value is specified, <command>COPY</command> limits
> +      the maximum tolerable number of errors while converting a column's input
> +      value into its data type.

If nothing is specified, then the maximum tolerable number of errors
is one, right? Should we state  this explicitly in the documentation?

> +COPY x from stdin with (on_error ignore, reject_limit 0);
How about a test where reject_limit is a string, but not
(case-intensively) 'infinity'?

> + CopyRejectLimits reject_limits; /* thresholds of reject_limit */

Why are there multiple thresholds? Can we have only one?

Other places look good to me.



pgsql-hackers by date:

Previous
From: Laurenz Albe
Date:
Subject: Re: Incremental backup from a streaming replication standby fails
Next
From: Jacob Champion
Date:
Subject: Re: Add support to TLS 1.3 cipher suites and curves lists