Re: speedup COPY TO for partitioned table. - Mailing list pgsql-hackers

From Kirill Reshke
Subject Re: speedup COPY TO for partitioned table.
Date
Msg-id CALdSSPhBPi1E5vWjk_+oq3p0ea5t4aEMJOKNd4Ni_zEPD6q+ng@mail.gmail.com
Whole thread Raw
In response to Re: speedup COPY TO for partitioned table.  (jian he <jian.universality@gmail.com>)
List pgsql-hackers
Hi!

First of all, a commit message does not need to contain SQL examples
of what it does. We should provide human-readable explanations and
that's it.

Next, about changes to src/test/regress/sql/copy2.sql. I find the sql
you used to test really unintuitive. How about CREATE TABLE ...
PARTITION OF syntax? It is also one command instead of two (create +
alter). It is also hard to say what partition structure is, because
column names on different partition levels are the same, just order is
switched. Let's change it to something more intuitive too?



-- 
Best regards,
Kirill Reshke



pgsql-hackers by date:

Previous
From: Andres Freund
Date:
Subject: Re: Index AM API cleanup
Next
From: Heikki Linnakangas
Date:
Subject: Re: Improve documentation regarding custom settings, placeholders, and the administrative functions