Re: POC: make mxidoff 64 bits - Mailing list pgsql-hackers

From Pavel Borisov
Subject Re: POC: make mxidoff 64 bits
Date
Msg-id CALT9ZEHm138m2rTi6-N_Xcm0ibfbK0b7yysdPHj1v144YUOFQg@mail.gmail.com
Whole thread Raw
In response to POC: make mxidoff 64 bits  (Maxim Orlov <orlovmg@gmail.com>)
Responses Re: POC: make mxidoff 64 bits
Re: POC: make mxidoff 64 bits
List pgsql-hackers
Hi, Maxim!

Previously we accessed offsets in shared MultiXactState without locks as 32-bit read is always atomic. But I'm not sure it's so when offset become 64-bit.
E.g. GetNewMultiXactId():

nextOffset = MultiXactState->nextOffset;
is outside lock. 

There might be other places we do the same as well. 

Regards,
Pavel Borisov
Supabase


pgsql-hackers by date:

Previous
From: Ranier Vilela
Date:
Subject: Re: Avoid dead code (contrib/pg_visibility/pg_visibility.c)
Next
From: Tatsuo Ishii
Date:
Subject: Re: Add memory/disk usage for WindowAgg nodes in EXPLAIN