Re: UNIQUE null treatment option - Mailing list pgsql-hackers

From Pavel Borisov
Subject Re: UNIQUE null treatment option
Date
Msg-id CALT9ZEHV1uQZzLY=adSF5Bhfj3DaSLCZRmUJCSF=5F0EjV5cUw@mail.gmail.com
Whole thread Raw
In response to Re: UNIQUE null treatment option  (Peter Eisentraut <peter.eisentraut@enterprisedb.com>)
Responses Re: UNIQUE null treatment option
List pgsql-hackers
Makes sense.  Here is an updated patch with this change.

I didn't end up renaming anynullkeys.  I came up with names like
"anyalwaysdistinctkeys", but in the end that felt too abstract, and
moreover, it would require rewriting a bunch of code comments that refer
to null values in this context.  Since as you wrote, anynullkeys is just
a local concern between two functions, this slight inaccuracy is perhaps
better than some highly general but unclear terminology.
Agree with that. With the comment it is clear how it works.

I've looked at the patch v3. It seems good enough for me. CFbot tests have also come green.
Suggest it is RFC now.

--
Best regards,
Pavel Borisov

Postgres Professional: http://postgrespro.com

pgsql-hackers by date:

Previous
From: Fabrice Chapuis
Date:
Subject: Re: Logical replication timeout problem
Next
From: Hamid Akhtar
Date:
Subject: Re: Parameter for planner estimate of recursive queries