Re: [PATCH] Improve amcheck to also check UNIQUE constraint in btree index. - Mailing list pgsql-hackers

From Pavel Borisov
Subject Re: [PATCH] Improve amcheck to also check UNIQUE constraint in btree index.
Date
Msg-id CALT9ZEFk3cMtWh2NoZtJr6QGpfdMVm=zKt_0=oYE-LQdmVfgow@mail.gmail.com
Whole thread Raw
In response to Re: [PATCH] Improve amcheck to also check UNIQUE constraint in btree index.  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
Hi, Tom!

On Fri, 10 May 2024, 04:43 Tom Lane, <tgl@sss.pgh.pa.us> wrote:
Alexander Korotkov <aekorotkov@gmail.com> writes:
> The revised patchset is attached.  I applied cosmetical changes.  I'm
> going to push it if no objections.

Is this really suitable material to be pushing post-feature-freeze?
It doesn't look like it's fixing any new-in-v17 issues.

                        regards, tom lane

I think these patches are nice-to-have optimizations and refactorings to make code look better. They are not necessary for the main feature. They don't fix any bugs. But they were requested in the thread, and make sense in my opinion. 

I really don't know what's the policy of applying code improvements other than bugfixes post feature-freeze. IMO they are safe to be appiled to v17, but they also could be added later.

Regards, 
Pavel Borisov
Supabase

pgsql-hackers by date:

Previous
From: Andy Fan
Date:
Subject: Re: Parallel CREATE INDEX for GIN indexes
Next
From: Bharath Rupireddy
Date:
Subject: Re: First draft of PG 17 release notes