Re: null iv parameter passed to combo_init() - Mailing list pgsql-hackers

From Zhihong Yu
Subject Re: null iv parameter passed to combo_init()
Date
Msg-id CALNJ-vTuaO+6hM4wY2aE0V7WdB56bwTXDp50Bn2U1ggmonVGbA@mail.gmail.com
Whole thread Raw
In response to Re: null iv parameter passed to combo_init()  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: null iv parameter passed to combo_init()
List pgsql-hackers


On Sat, Jan 8, 2022 at 11:32 PM Tom Lane <tgl@sss.pgh.pa.us> wrote:
Noah Misch <noah@leadboat.com> writes:
> On further thought, I would write it this way:

> -             else
> +             else if (ivlen != 0)
>                       memcpy(ivbuf, iv, ivlen);

FWIW, I liked the "ivlen > 0" formulation better.  They should be
equivalent, because ivlen is unsigned, but it just seems like "> 0"
is more natural.

                        regards, tom lane

Patch v4 is attached.

Cheers
Attachment

pgsql-hackers by date:

Previous
From: Julien Rouhaud
Date:
Subject: Re: Multiple Query IDs for a rewritten parse tree
Next
From: "Wei Sun"
Date:
Subject: Add lasterrno setting for dir_existsfile()