remove unnecessary assignment to tmask in DecodeDateTime - Mailing list pgsql-hackers

From Zhihong Yu
Subject remove unnecessary assignment to tmask in DecodeDateTime
Date
Msg-id CALNJ-vTnQSK=aZxDaWUj=ikXS3f6_yB8G0pFp5gScs3Se2r+Vw@mail.gmail.com
Whole thread Raw
List pgsql-hackers
Hi,
I was looking at the code in DecodeDateTime() around line 1382:

               tmask = DTK_M(type);

In case type is UNKNOWN_FIELD, the above macro would shift 1 left 31 bits which cannot be represented in type 'int'.

Looking down in the same function, we can see that tmask is assigned for every legitimate case.

If my understanding is correct, please take a look at the proposed patch.

Thanks
Attachment

pgsql-hackers by date:

Previous
From: Melanie Plageman
Date:
Subject: Re: pg_stat_bgwriter.buffers_backend is pretty meaningless (and more?)
Next
From: Andres Freund
Date:
Subject: Re: remap the .text segment into huge pages at run time