Re: [POC] Allow flattening of subquery with a link to upper query - Mailing list pgsql-hackers

From Zhihong Yu
Subject Re: [POC] Allow flattening of subquery with a link to upper query
Date
Msg-id CALNJ-vTa5VgvV1NPRHnypdnbx-fhDu7vWp73EkMUbZRpNHTYQQ@mail.gmail.com
Whole thread Raw
In response to [POC] Allow flattening of subquery with a link to upper query  (Andrey Lepikhov <a.lepikhov@postgrespro.ru>)
Responses Re: [POC] Allow flattening of subquery with a link to upper query  (Andrey Lepikhov <a.lepikhov@postgrespro.ru>)
List pgsql-hackers
Hi,
For contain_placeholders():

+   if (IsA(node, Query))
+       return query_tree_walker((Query *) node, contain_placeholders, context, 0);
+   else if (IsA(node, PlaceHolderVar))

The `else` is not needed.

For correlated_t struct, it would be better if the fields have comments.

+                    * (for grouping, as an example). So, revert its status to
+                    * a full valued entry.

full valued -> fully valued

Cheers

pgsql-hackers by date:

Previous
From: Nikita Malakhov
Date:
Subject: Re: Pluggable toaster
Next
From: David Rowley
Date:
Subject: Re: Warning about using pg_stat_reset() and pg_stat_reset_shared()