On Sat, Sep 4, 2021 at 12:56 PM Jaime Casanova
<jcasanov@systemguards.com.ec> wrote:
>
> patch 01: does apply but doesn't compile, attached the compile errors.
> patch 04: does not apply clean.
Thanks for taking a look! I've rebased & made it compile again. v7 attached.
Yours,
Paul
Hi,
For v7-0001-Add-PERIODs.patch :
+ * Portions Copyright (c) 1996-2018, PostgreSQL Global Development Group
It seems the year (2018) should be updated to 2021.
For RemovePeriodById(), it seems table_open() can be called after SearchSysCache1(). This way, if HeapTupleIsValid(tup) is true, table_open() can be skipped.
For tablecmds.c, AT_PASS_ADD_PERIOD is defined as 5 with AT_PASS_ADD_CONSTR etc moved upward. Do we need to consider compatibility ?
There are a few TODO's such as:
+ * TODO: What about periods?
Are they going to be addressed in the next round of patches ?
There seems to be some overlap between ATExecAddPeriod() and AddRelationNewPeriod().
Is it possible to reduce code duplication ?
Cheers