Re: Bugs in copyfuncs/equalfuncs support for JSON node types - Mailing list pgsql-hackers

From Zhihong Yu
Subject Re: Bugs in copyfuncs/equalfuncs support for JSON node types
Date
Msg-id CALNJ-vT8OL3E5LNx4D+ubUe9JBJWydEXn60j0=ca+w+wio+79g@mail.gmail.com
Whole thread Raw
In response to Bugs in copyfuncs/equalfuncs support for JSON node types  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers


On Mon, Jul 4, 2022 at 6:23 PM Tom Lane <tgl@sss.pgh.pa.us> wrote:
In reviewing Peter's patch to auto-generate the backend/nodes
support files, I compared what the patch's script produces to
what is in the code now.  I found several discrepancies in the
recently-added parse node types for JSON functions, and as far
as I can see every one of those discrepancies is an error in
the existing code.  Some of them are relatively harmless
(e.g. COPY_LOCATION_FIELD isn't really different from
COPY_SCALAR_FIELD), but some of them definitely are live bugs.
I propose the attached patch.

                        regards, tom lane

Hi,
Patch looks good to me.

Thanks 

pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Bugs in copyfuncs/equalfuncs support for JSON node types
Next
From: Tom Lane
Date:
Subject: Re: TAP output format in pg_regress