Re: Add SPLIT PARTITION/MERGE PARTITIONS commands - Mailing list pgsql-hackers

Hi,

+attachPartTable(List **wqueue, Relation rel, Relation partition, PartitionBoundSpec *bound) 

I checked naming of existing methods, such as AttachPartitionEnsureIndexes.

I think it would be better if the above method is named attachPartitionTable.

+   if (!defaultPartCtx && OidIsValid(defaultPartOid))
+   {
+       pc = createSplitPartitionContext(table_open(defaultPartOid, AccessExclusiveLock));

Since the value of pc would be passed to defaultPartCtx, there is no need to assign to pc above. You can assign directly to defaultPartCtx.

+   /* Drop splitted partition. */

splitted -> split

+   /* Rename new partition if it is need. */

need -> needed.

Cheers