Postgres Pro
Downloads
Home   >   mailing lists

Re: Dump public schema ownership & seclabels - Mailing list pgsql-hackers

From Zhihong Yu
Subject Re: Dump public schema ownership & seclabels
Date
Msg-id CALNJ-vSqGYkEDx3i16Bne-D224dWBRpatweTbiu0qY6uQmDu9A@mail.gmail.com
Whole thread Raw
In response to Re: Dump public schema ownership & seclabels  (Asif Rehman <asifr.rehman@gmail.com>)
Responses Re: Dump public schema ownership & seclabels
List pgsql-hackers
Tree view


On Sat, May 1, 2021 at 8:16 AM Asif Rehman <asifr.rehman@gmail.com> wrote:
The following review has been posted through the commitfest application:
make installcheck-world:  tested, passed
Implements feature:       tested, passed
Spec compliant:           tested, passed
Documentation:            not tested

Hi,

I have tested this patch. This patch still applies and it works well.

Regards,
Asif

The new status of this patch is: Ready for Committer

For public-schema-comment-dump-v2.patch :

+       if (ncomments == 0)
+       {
+           comments = &empty_comment;
+           ncomments = 1;
+       }
+       else if (strcmp(comments->descr, (fout->remoteVersion >= 80300 ?
+                                         "standard public schema" :
+                                         "Standard public schema")) == 0)
+       {
+           ncomments = 0;

Is it possible that, in the case ncomments > 0, there are more than one comment ?
If not, an assertion can be added in the second if block above.

Cheers

pgsql-hackers by date:

Previous
From: Chapman Flack
Date:
Subject: Re: Granting control of SUSET gucs to non-superusers
Next
From: Dmitry Dolgov
Date:
Subject: Re: [PATCH] Identify LWLocks in tracepoints