Hi,
bq. within this range. Table AMs where scanning ranges of TIDs does not make
sense or is difficult to implement efficiently may choose to not implement
Is there criterion on how to judge efficiency ?
+ if (tidopexpr->exprtype == TIDEXPR_LOWER_BOUND)
...
+ if (tidopexpr->exprtype == TIDEXPR_UPPER_BOUND)
The if statement for upper bound should be prefixed with 'else', right ?
+ * TidRecheck -- access method routine to recheck a tuple in EvalPlanQual
...
+TidRangeRecheck(TidRangeScanState *node, TupleTableSlot *slot)
The method name in the comment doesn't match the real method name.
+ * ExecTidRangeScan(node)
...
+ExecTidRangeScan(PlanState *pstate)
Parameter names don't match.
Cheers
On Thu, 21 Jan 2021 at 18:16, David Rowley <dgrowleyml@gmail.com> wrote:
> I've implemented this in the attached.
The bug fix in 0001 is now committed, so I'm just attaching the 0002
patch again after having rebased... This is mostly just to keep the
CFbot happy.
David
