On Mon, Jul 19, 2021 at 9:14 PM Bruce Momjian <bruce@momjian.us> wrote:
On Wed, Jul 14, 2021 at 09:03:21AM -0700, Zhihong Yu wrote: > On Thu, Jul 8, 2021 at 10:22 AM Zhihong Yu <zyu@yugabyte.com> wrote: > On Wed, Jun 30, 2021 at 9:35 AM Bruce Momjian <bruce@momjian.us> wrote: > > On Tue, Jun 29, 2021 at 06:49:45PM +0200, Daniel Gustafsson wrote: > > > On 29 Jun 2021, at 18:50, Zhihong Yu <zyu@yugabyte.com> wrote: > > > > > Now that PG 15 is open for commit, do you think the patch can land > ? > > > > Adding it to the commitfest patch tracker is a good way to ensure > it's not > > forgotten about: > > > > https://commitfest.postgresql.org/33/ > > OK, I have been keeping it in my git tree since I wrote it and will > apply it in the next few days. > Thanks, Bruce. > > Hopefully you can get to this soon. > > Bruce: > Please see if the patch can be integrated now.
I found a mistake in my most recent patch. For example, in master we see this output:
Obviously this should return '1 mon 26 days', but with my most recent patch, it returned '1 mon 25 days'. Turns out I had not properly used rint() in AdjustFractDays, and in fact the function is now longer needed because it is just a multiplication and an rint().
