Postgres Pro
Downloads
Home   >   mailing lists

Re: [PATCH] Allow multiple recursive self-references - Mailing list pgsql-hackers

From Zhihong Yu
Subject Re: [PATCH] Allow multiple recursive self-references
Date
Msg-id CALNJ-vSXdj-gvkpTdSQw8EMM-Nax7ibJ8HzC_SDbYhk5HENHyg@mail.gmail.com
Whole thread Raw
In response to Re: [PATCH] Allow multiple recursive self-references  (Denis Hirn <denis.hirn@uni-tuebingen.de>)
Responses Re: [PATCH] Allow multiple recursive self-references  (Denis Hirn <denis.hirn@uni-tuebingen.de>)
List pgsql-hackers
Tree view


On Tue, Aug 17, 2021 at 5:58 AM Denis Hirn <denis.hirn@uni-tuebingen.de> wrote:
> The tests fail when you build with assertions enabled (configure --enable-cassert).

Thank you for pointing that out. The new version of this patch fixes that.
The tests are working properly now. All style related issues are fixed as well.

Best wishes,
  -- Denis


Hi,
+                   selfrefcountL = cstate->selfrefcount;
+                   cstate->selfrefcount = selfrefcount;

Maybe the variable  selfrefcountL can be renamed slightly (e.g. curr_selfrefcount) so that the code is easier to read.

Cheers

pgsql-hackers by date:

Previous
From: Zhihong Yu
Date:
Subject: Re: Allow parallel DISTINCT
Next
From: Bruce Momjian
Date:
Subject: Re: PG14: Avoid checking output-buffer-length for every encoded byte during pg_hex_encode