Postgres Pro
Downloads
Home   >   mailing lists

Re: Table AM modifications to accept column projection lists - Mailing list pgsql-hackers

From Zhihong Yu
Subject Re: Table AM modifications to accept column projection lists
Date
Msg-id CALNJ-vRoS=K9dqv2thYCnNXfo8uEbZbQv1NizGLCGx9KDEpK0w@mail.gmail.com
Whole thread Raw
In response to Re: Table AM modifications to accept column projection lists  (Soumyadeep Chakraborty <soumyadeep2007@gmail.com>)
List pgsql-hackers
Tree view
Hi, Soumyadeep:
Happy New Year.

+typedef struct neededColumnContext
+{
+   Bitmapset **mask;
+   int n;

+ * n specifies the number of allowed entries in mask: we use
+ * it for bounds-checking in the walker above.

I think the code would be easier to read if the above comment is moved or copied for field n of neededColumnContext

Cheers

On Thu, Dec 31, 2020 at 1:03 PM Soumyadeep Chakraborty <soumyadeep2007@gmail.com> wrote:
Hey Masahiko,

I added it to the Jan CF (https://commitfest.postgresql.org/31/2922/).

PFA a rebased version against latest head.

Regards,
Soumyadeep

pgsql-hackers by date:

Previous
From: Peter Geoghegan
Date:
Subject: Re: Deleting older versions in unique indexes to avoid page splits
Next
From: Josef Šimánek
Date:
Subject: [PATCH] Simple progress reporting for COPY command