naming of async_mode parameter - Mailing list pgsql-hackers

From Zhihong Yu
Subject naming of async_mode parameter
Date
Msg-id CALNJ-vRM3vH24hv1i8R8h6+ocOib04wBYGycuuy_Jjo2j6S4CA@mail.gmail.com
Whole thread Raw
Responses Re: naming of async_mode parameter
List pgsql-hackers
Hi, Etsuro-san:
I was looking at
  Fix EXPLAIN ANALYZE for async-capable nodes.

which adds the following parameter / field:

+   bool        async_mode;     /* true if node is in async mode */

async_mode implies an enum: {sync, async}
Since there are only two values, the data type is bool. I think it should be named is_async.

What do you think?

Cheers

pgsql-hackers by date:

Previous
From: Bruce Momjian
Date:
Subject: Re: PG 14 release notes, first draft
Next
From: Bruce Momjian
Date:
Subject: Re: PG 14 release notes, first draft