Re: Rename of triggers for partitioned tables - Mailing list pgsql-hackers

From Zhihong Yu
Subject Re: Rename of triggers for partitioned tables
Date
Msg-id CALNJ-vRE3F1_s9bt_d05RMgLdYwQuig8aUbg2F=bhRtYbfvzOQ@mail.gmail.com
Whole thread Raw
In response to Re: Rename of triggers for partitioned tables  (Arne Roland <A.Roland@index.de>)
Responses Re: Rename of triggers for partitioned tables  (Arne Roland <A.Roland@index.de>)
List pgsql-hackers


On Sat, Jun 26, 2021 at 10:08 AM Arne Roland <A.Roland@index.de> wrote:
From: Alvaro Herrera <alvherre@alvh.no-ip.org>
Sent: Saturday, June 26, 2021 18:36
Subject: Re: Rename of triggers for partitioned tables
 
> I'll have a look during the commitfest which starts late next week.

Thank you!

> (However, I'm fairly sure that it won't be in released versions ...
> it'll only be fixed in the version to be released next year, postgres
> 15.  Things that are clear bug fixes can be applied
> in released versions, but this patch probably changes behavior in ways
> that are not acceptable in released versions.  Sorry about that.)

I never expected any backports. Albeit I don't know anyone, who would mind, I agree with you on that assessment. This is very annoying, but not really breaking the product.

Sure, I was hoping for pg14 initially. But I will survive another year of gexec.
I am grateful you agreed to have a look!

Regards
Arne

Hi, Arne:
It seems the patch no longer applies cleanly on master branch.
Do you mind updating the patch ?

Thanks

1 out of 7 hunks FAILED -- saving rejects to file src/backend/commands/trigger.c.rej
patching file src/backend/parser/gram.y
Hunk #1 succeeded at 8886 (offset 35 lines).
patching file src/backend/utils/adt/ri_triggers.c
Reversed (or previously applied) patch detected!  Assume -R? [n]
Apply anyway? [n]
Skipping patch.
1 out of 1 hunk ignored -- saving rejects to file src/backend/utils/adt/ri_triggers.c.rej 

pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: [PATCH] Make jsonapi usable from libpq
Next
From: Tom Lane
Date:
Subject: Re: [PATCH] Make jsonapi usable from libpq