Home > mailing lists

Re: Missing update of all_hasnulls in BRIN opclasses - Mailing list pgsql-hackers

From	Zhihong Yu
Subject	Re: Missing update of all_hasnulls in BRIN opclasses
Date	October 23, 2022 02:02:54
Msg-id	CALNJ-vQ4oG=PheN-nM+-5oK-x_Pe5sp5yNshckTKRtkoiWAL0Q@mail.gmail.com Whole thread Raw
In response to	Missing update of all_hasnulls in BRIN opclasses (Tomas Vondra <tomas.vondra@enterprisedb.com>)
List	pgsql-hackers

Hi, Tomas:

For 0002-fixup-brin-has_nulls-20221022.patch :

+ first_row = (bval->bv_hasnulls && bval->bv_allnulls);
+
+ if (bval->bv_hasnulls && bval->bv_allnulls)

It seems the if condition can be changed to `if (first_row)` which is more readable.

Chhers

From: Nikita Malakhov
Date: 23 October 2022, 00:00:12
Subject: Re: Pluggable toaster

From: Tomas Vondra
Date: 23 October 2022, 02:17:55
Subject: Re: PATCH: Using BRIN indexes for sorted output