On Mon, Aug 30, 2021 at 8:23 AM Greg Nancarrow <
gregn4422@gmail.com> wrote:
>
> On Fri, Aug 27, 2021 at 4:13 PM vignesh C <
vignesh21@gmail.com> wrote:
> >
> > I have implemented this in the 0003 patch, I have kept it separate to
> > reduce the testing effort and also it will be easier if someone
> > disagrees with the syntax. I will merge it to the main patch later
> > based on the feedback. Attached v22 patch has the changes for the
> > same.
>
> Just experimenting with the new syntax so far, and seeing some new
> messages and docs, I have the following suggestions for improvements:
>
> src/backend/commands/publicationcmds.c
>
> (1)
> BEFORE:
> for table/for all tables in schema should be specified before the object
> AFTER:
> FOR TABLE / FOR ALL TABLES IN SCHEMA should be specified before the
> table/schema name(s)
Modified it to "FOR TABLE/FOR ALL TABLES IN SCHEMA should be specified before the table/schema name(s)", I felt we need not have space before and after "/", I had seen it is specified similarly in few other places.
> (2)
> BEFORE:
> Tables cannot be added, dropped or set on FOR ALL TABLES publications.
> AFTER:
> Tables cannot be added to, dropped from, or set on FOR ALL TABLES publications.
Modified
> (3)
> BEFORE:
> Schemas cannot be added, dropped or set on FOR ALL TABLES publications.
> AFTER:
> Schemas cannot be added to, dropped from, or set on FOR ALL TABLES publications.
Modified
> v22-0002
>
> doc/src/sgml/ref/create_publication.sgml
>
> (1)
> BEFORE:
> + Create a publication that publishes all changes for users and departments
> + table and that publishes all changes for all the tables present in the
> AFTER:
> + Create a publication that publishes all changes for tables "users" and
> + "departments" and that publishes all changes for all the tables
> present in the
Modified.
I have fixed these comments as part of v23 patch attached at [1].
[1] -
https://www.postgresql.org/message-id/CALDaNm0xmqJeQEfV5Wnj2BawM%3DsdFdfOXz5N%2BgGG3WB6k9%3Dtdw%40mail.gmail.com
Regards,
Vignesh
