Re: Unused header file inclusion - Mailing list pgsql-hackers

From vignesh C
Subject Re: Unused header file inclusion
Date
Msg-id CALDaNm2shkzdA3M=KkrwW9GGYf79ZD9=zfOPHRWs=VXKVEectA@mail.gmail.com
Whole thread Raw
In response to Re: Unused header file inclusion  (Michael Paquier <michael@paquier.xyz>)
Responses Re: Unused header file inclusion  (Amit Kapila <amit.kapila16@gmail.com>)
List pgsql-hackers
On Wed, Jul 31, 2019 at 11:26 AM Michael Paquier <michael@paquier.xyz> wrote:
>
> On Wed, Jul 31, 2019 at 11:19:08AM +0530, vignesh C wrote:
> > I noticed that there are many header files being included which need
> > not be included.  I have tried this in a few files and found the
> > compilation and regression to be working.  I have attached the patch
> > for the files that  I tried.  I tried this in CentOS, I did not find
> > the header files to be platform specific.
> > Should we pursue this further and cleanup in all the files?
>
> Do you use a particular method here or just manual deduction after
> looking at each file individually?  If this can be cleaned up a bit, I
> think that's welcome.  The removal of headers is easily forgotten when
> moving code from one file to another...
>
Thanks Michael.
I'm writing some perl scripts to identify this.
The script will scan through all the files, make changes,
and verify.
Finally it will give the changed files.

Regards,
Vignesh
EnterpriseDB: http://www.enterprisedb.com



pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: Unused header file inclusion
Next
From: Ning Yu
Date:
Subject: Re: Possible race condition in pg_mkdir_p()?