On Wed, 21 May 2025 at 16:11, shveta malik <shveta.malik@gmail.com> wrote:
> Please find few more comments:
>
> 1)
> Temporary sequences will not be replicated, shall we mention this in
> doc under '29.7. Replicating Sequences'?
I added it create publication "ALL SEQUENCES" section as similar
restriction about table is mentioned there
> 2)
> CREATE publication pub1 for all sequences WITH (publish = 'insert,
> update, truncate');
>
> I think it does not make sense to give 'publish' as above (or
> publish_via_partition_root) for 'all sequences' publication. Shall we
> display a WARNING that such will be ignored for 'all sequences' and
> let the create-publication go ahead? Thoughts? Also the doc for
> publish* option in the CREATE-PUBLICATION page needs to specify that
> these options are not-applicable for ALL SEQUENCES publication.
I felt no need to add a warning, just adding to documentation would be enough.
> 3)
> It will be good to move create_publication.sgml as well to the last
> patch where all other doc changes are present. I was trying to find
> this change in the last patch but ultimately found it in pacth002.
Moved
> 4)
> Currently the log is:
>
> ------
> LOG: logical replication sequence synchronization worker for
> subscription "sub1" has started
> LOG: Logical replication sequence synchronization for subscription
> "sub1" - total unsynchronized: 1; batch #1 = 1 attempted, 0 succeeded,
> 1 mismatched
> WARNING: parameters differ for the remote and local sequences
> ("public.myseq34") for subscription "sub1"
> HINT: Alter/Re-create local sequences to have the same parameters as
> the remote sequences.
> WARNING: sequence synchronization worker failed: one or more
> sequences have mismatched parameters between the publisher and
> subscriber
> LOG: logical replication sequence synchronization worker for
> subscription "sub1" has finished
> -----
>
> Do we need both?
Removed it.
The attached v20250522 patch has the changes for the same.
Regards,
Vignesh
