On Sat, 11 Nov 2023 at 00:03, Krishnakumar R <kksrcv001@gmail.com> wrote:
>
> Thank you for review, Peter.
>
> Makes sense on the split part. Was starting to think in same lines, at the end of last iteration. Will come back
shortly.
>
> On Fri, Nov 10, 2023 at 12:48 AM Peter Eisentraut <peter@eisentraut.org> wrote:
>>
>> On 17.10.23 03:32, Krishnakumar R wrote:
>> >> The version comparison has been moved from initdb to bootstrap. This
>> >> created some compatibility problems with windows tests. For now I kept
>> >> the version check to not have \n added, which worked fine and serves
>> >> the purpose. However hoping to have something better in v3 in addition
>> >> to addressing any other comments.
>> >
>> > With help from Thomas, figured out that on windows fopen uses binary
>> > mode in the backend which causes issues with EOL. Please find the
>> > attached patch updated with a fix for this.
>>
>> I suggest that this patch set be split up into three incremental parts:
>>
>> 1. Move some build-time settings from initdb to postgres.bki.
>> 2. The database locale handling.
>> 3. The bki file handling.
>>
>> Each of these topics really needs a separate detailed consideration.
The patch which you submitted has been awaiting your attention for
quite some time now. As such, we have moved it to "Returned with
Feedback" and removed it from the reviewing queue. Depending on
timing, this may be reversible. Kindly address the feedback you have
received, and resubmit the patch to the next CommitFest.
Regards,
Vignesh
