Downloads
Home   >   mailing lists

Re: Document slot's restart_lsn can go backward - Mailing list pgsql-hackers

From vignesh C
Subject Re: Document slot's restart_lsn can go backward
Date
Msg-id CALDaNm1qBC9cGeyjACxtcHtZABd9mHQ2qaQsARNXXP1BXQFiDw@mail.gmail.com
Whole thread Raw
In response to Re: Document slot's restart_lsn can go backward  (Amit Kapila <amit.kapila16@gmail.com>)
Responses Re: Document slot's restart_lsn can go backward
List pgsql-hackers
Tree view 
On Mon, 21 Jul 2025 at 11:04, Amit Kapila <amit.kapila16@gmail.com> wrote:
>
> On Fri, Jul 18, 2025 at 5:11 PM Alexander Korotkov <aekorotkov@gmail.com> wrote:
> >
> > While working on the patch fixing the situation when slot's
> > restart_lsn ends up pointing to a removed WAL segment [1], we
> > discovered that sometimes slot's restart_lsn can go backward
> > [2][3][4].  Hayato Kuroda proposed a patch [5], which improves
> > comments by describing this behavior.  As proposed by Amit Kapila [6],
> > I'm starting a new thread about this comments patch.
> >
> > Any feedback on this patch?
> >
>
> I have tried to slightly improve the comments. You can include the
> suggestions, if you and/or kuroda-san thinks that the suggestions make
> the patch better.

Your changes look good to me.

Regards,
Vignesh

pgsql-hackers by date:

Previous
From: shveta malik
Date:
Subject: Re: POC: enable logical decoding when wal_level = 'replica' without a server restart
Next
From: Aleksander Alekseev
Date:
Subject: Re: Missing NULL check after calling ecpg_strdup