Re: alter table set TABLE ACCESS METHOD - Mailing list pgsql-hackers

From vignesh C
Subject Re: alter table set TABLE ACCESS METHOD
Date
Msg-id CALDaNm1f_6DoFycXBVu6fEKeWjm3Xf3gSM5TDp13tiMY3zpThw@mail.gmail.com
Whole thread Raw
In response to Re: alter table set TABLE ACCESS METHOD  (Jeff Davis <pgsql@j-davis.com>)
List pgsql-hackers
On Fri, Jul 16, 2021 at 9:19 AM Justin Pryzby <pryzby@telsasoft.com> wrote:
>
> rebased.
>
> Also, there were two redundant checks for multiple SET ACCESS METHOD commands.
> But one of them wasn't hit if the ALTER was setting the current AM due to the
> no-op test.
>
> I think it's better to fail in every case, and not just sometimes (especially
> if we were to use ERRCODE_SYNTAX_ERROR).
>
> I included my 2ndary patch allowing to set the AM of partitioned table, same as
> for a tablespace.

One of the tests is failing, please post an updated patch for this:
create_am.out       2021-07-22 10:34:56.234654166 +0530
@@ -177,6 +177,7 @@
 (1 row)

 -- CREATE TABLE ..  PARTITION BY supports USING
+-- new partitions will inherit from the current default, rather the
partition root
 CREATE TABLE tableam_parted_heap2 (a text, b int) PARTITION BY list
(a) USING heap2;
 SET default_table_access_method = 'heap';
 CREATE TABLE tableam_parted_a_heap2 PARTITION OF tableam_parted_heap2
FOR VALUES IN ('a');

Regards,
Vignesh



pgsql-hackers by date:

Previous
From: Pavel Stehule
Date:
Subject: Re: proposal: enhancing plpgsql debug API - returns text value of variable content
Next
From: Amit Kapila
Date:
Subject: Re: Next Steps with Hash Indexes