Re: CREATE SUBSCRIPTION - add missing test case - Mailing list pgsql-hackers

From vignesh C
Subject Re: CREATE SUBSCRIPTION - add missing test case
Date
Msg-id CALDaNm1aPFHe1DA-BJGb+7YqFCMRYHTOf2xSXLKCEThTSDLj1Q@mail.gmail.com
Whole thread Raw
In response to Re: CREATE SUBSCRIPTION - add missing test case  (vignesh C <vignesh21@gmail.com>)
List pgsql-hackers
On Tue, 20 Aug 2024 at 08:21, Peter Smith <smithpb2250@gmail.com> wrote:
>
> On Fri, Aug 16, 2024 at 2:15 PM vignesh C <vignesh21@gmail.com> wrote:
> >
>
> Thanks for the review.
>
> >
> > I agree currently there is no test to hit this code. I'm not sure if
> > this is the correct location for the test, should it be included in
> > the 008_diff_schema.pl file?
>
> Yes, that is a better home for this test. Done as suggested in
> attached patch v2.

Thanks, this looks good to me.

Regards,
Vignesh



pgsql-hackers by date:

Previous
From: vignesh C
Date:
Subject: Re: long-standing data loss bug in initial sync of logical replication
Next
From: Yugo Nagata
Date:
Subject: Re: define PG_REPLSLOT_DIR