On Mon, Oct 11, 2021 at 12:50 PM houzj.fnst@fujitsu.com
<houzj.fnst@fujitsu.com> wrote:
>
> On Monday, October 11, 2021 2:39 PM vignesh C <vignesh21@gmail.com> wrote:
> >
> > These comments are fixed in the v38 patch attached.
>
> Thanks for updating the patches.
> Here are a few comments on the v38-0004-Doc patch.
>
> 1.
> + <para>
> + Adding/Setting a table that is part of schema specified in
> + <literal>ALL TABLES IN SCHEMA</literal>, adding/setting a schema to a
> + publication along with same schema's table specified with
> + <literal>TABLE</literal>, adding/setting a schema to a publication that
> + already has a table that is part of specified schema or adding/setting a
> + table to a publication that already has a table's schema as part of
> + specified schema is not supported.
>
> ISTM we can remove the description "adding/setting a schema to a publication
> along with same schema's table specified with <literal>TABLE</literal>",
> because it seems the same as the first mentioned case "Adding/Setting a table
> that is part of schema specified in <literal>ALL TABLES IN SCHEMA</literal>"
Modified
> 2.
>
> +</programlisting></para>
> +
> + <para>
> + Add some schemas to the publication:
> +<programlisting>
> +ALTER PUBLICATION sales_publication ADD ALL TABLES IN SCHEMA marketing_june, sales_june;
> +</programlisting>
> + </para>
> +
> + <para>
> + Add some tables and schemas to the publication:
> ...
> +
> + <para>
> + Drop some schemas from the publication:
> ...
> + <para>
> + Set some schemas to the publication:
> +<programlisting>
> +ALTER PUBLICATION production_publication SET ALL TABLES IN SCHEMA production_september, production_october;
>
> Personally, I think we don't need the example about DROP and SET here.
> The example of ADD seems sufficient.
Modified
> 3.
> +</programlisting>
> + </para>
> +
> + <para>
> + Create a publication that publishes all changes for all the tables present in
> + the schema "production":
> +<programlisting>
> +CREATE PUBLICATION production_publication FOR ALL TABLES IN SCHEMA production;
> +</programlisting>
> + </para>
> ...
> + <para>
> + Create a publication that publishes all changes for all the tables present in
> + the schemas "marketing" and "sales":
> +<programlisting>
> +CREATE PUBLICATION sales_publication FOR ALL TABLES IN SCHEMA marketing, sales;
>
> I think the example for publishing all the tables in schemas "marketing" and
> "sales" is sufficient, the example for pulishing signal schema seems can be
> removed.
Modified
The attached v39 patch has the fixes for the above issues.
Regards,
Vignesh
