Postgres Pro
Downloads
Home   >   mailing lists

Re: [PATCH]Comment improvement in publication.sql - Mailing list pgsql-hackers

From vignesh C
Subject Re: [PATCH]Comment improvement in publication.sql
Date
Msg-id CALDaNm1P6hdJT-wkURo=Wc3m9Sqn7aNf6a6wqFg7uF1MTbab9Q@mail.gmail.com
Whole thread Raw
In response to RE: [PATCH]Comment improvement in publication.sql  ("tanghy.fnst@fujitsu.com" <tanghy.fnst@fujitsu.com>)
Responses RE: [PATCH]Comment improvement in publication.sql
List pgsql-hackers
Tree view 
On Wed, Dec 8, 2021 at 11:07 AM tanghy.fnst@fujitsu.com
<tanghy.fnst@fujitsu.com> wrote:
>
> On Wednesday, December 8, 2021 1:49 PM, vignesh C <vignesh21@gmail.com> wrote:
>
> > The patch no longer applies, could you post a rebased patch.
>
> Thanks for your kindly reminder. Attached a rebased patch.
> Some changes in v4 patch has been fixed by 5a28324, so I deleted those changes.

Thanks for the updated patch, should we make a similar change in
AlterPublicationTables Function header to mention Set too:
/*
* Add or remove table to/from publication.
*/
static void
AlterPublicationTables(AlterPublicationStmt *stmt, HeapTuple tup,
List *tables, List *schemaidlist)

Regards,
Vignesh

pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: Remove pg_strtouint64(), use strtoull() directly
Next
From: Robert Haas
Date:
Subject: Re: Remove pg_strtouint64(), use strtoull() directly