Re: ALTER ROLE documentation improvement - Mailing list pgsql-hackers

From vignesh C
Subject Re: ALTER ROLE documentation improvement
Date
Msg-id CALDaNm1ASWOxqA7-boZLm2TAXM5frp0RmCM2-FGxJHoXGVvO0g@mail.gmail.com
Whole thread Raw
In response to Re: ALTER ROLE documentation improvement  (Nathan Bossart <nathandbossart@gmail.com>)
Responses Re: ALTER ROLE documentation improvement
List pgsql-hackers
On Tue, 26 Sept 2023 at 04:38, Nathan Bossart <nathandbossart@gmail.com> wrote:
>
> On Fri, Sep 15, 2023 at 02:25:38PM -0700, Yurii Rashkovskii wrote:
> > Thank you for the feedback. I've updated the glossary and updated the
> > terminology to be consistent. Please see the new patch attached.
>
> Thanks for the new version of the patch.
>
>       This user owns all system catalog tables in each database.  It is also the role
>       from which all granted permissions originate.  Because of these things, this
> -     role may not be dropped.
> +     role may not be dropped. This role must always be a superuser, it can't be changed
> +     to be a non-superuser.
>
> I think we should move this note to the sentence just below that mentions
> its superuserness.  Maybe it could look something like this:
>
>         This role also behaves as a normal database superuser, and its
>         superuser status cannot be revoked.

Modified

> +   Database superusers can change any of these settings for any role, except for
> +   changing <literal>SUPERUSER</literal> to <literal>NOSUPERUSER</literal>
> +   for a <glossterm linkend="glossary-bootstrap-superuser">bootstrap superuser</glossterm>.
>
> nitpick: s/a bootstrap superuser/the bootstrap superuser

Modified

>  #: commands/user.c:871
>  #, c-format
> -msgid "The bootstrap user must have the %s attribute."
> +msgid "The bootstrap superuser must have the %s attribute."
>  msgstr "Der Bootstrap-Benutzer muss das %s-Attribut haben."
>
> No need to update the translation files.  Those are updated separately in
> the pgtranslation repo.

Removed the translation changes

The attached v3 version patch has the changes for the same.

Regards,
Vignesh

Attachment

pgsql-hackers by date:

Previous
From: Peter Eisentraut
Date:
Subject: Re: Escape output of pg_amcheck test
Next
From: vignesh C
Date:
Subject: Re: There should be a way to use the force flag when restoring databases