Re: [PATCH] Expand character set for ltree labels - Mailing list pgsql-hackers

From vignesh C
Subject Re: [PATCH] Expand character set for ltree labels
Date
Msg-id CALDaNm0P20=FkAVVSHRJ9s+SHbxdQzBS71REoGhSKnPNeSQd1Q@mail.gmail.com
Whole thread Raw
In response to Re: [PATCH] Expand character set for ltree labels  (Garen Torikian <gjtorikian@gmail.com>)
Responses Re: [PATCH] Expand character set for ltree labels
List pgsql-hackers
On Thu, 6 Oct 2022 at 03:35, Garen Torikian <gjtorikian@gmail.com> wrote:
>
> After digging into it, you are completely correct. I had to do a bit more reading to understand the relationships
betweenUTF-8 and wchar, but ultimately the existing locale support works for my use case.
 
>
> Therefore I have updated the patch with three much smaller changes:
>
> * Support for `-` in addition to `_`
> * Expanding the limit to 512 chars (from the existing 256); again it's not uncommon for non-English strings to be
muchlonger
 
> * Fixed the documentation to expand on what the ltree label's relationship to the DB locale is

The patch does not apply on top of HEAD as in [1], please post a rebased patch:
=== Applying patches on top of PostgreSQL commit ID
e351f85418313e97c203c73181757a007dfda6d0 ===
=== applying patch ./0002-Expand-character-set-for-ltree-labels.patch
patching file contrib/ltree/expected/ltree.out
patching file contrib/ltree/ltree.h
Hunk #2 FAILED at 126.
1 out of 2 hunks FAILED -- saving rejects to file contrib/ltree/ltree.h.rej

[1] - http://cfbot.cputube.org/patch_41_3929.log

Regards,
Vignesh



pgsql-hackers by date:

Previous
From: vignesh C
Date:
Subject: Re: Cygwin cleanup
Next
From: vignesh C
Date:
Subject: Re: [PATCH]Feature improvement for MERGE tab completion