Re: psql - factor out echo code - Mailing list pgsql-hackers

From vignesh C
Subject Re: psql - factor out echo code
Date
Msg-id CALDaNm007JDVCYgpKnaYC6zYO+JBWfqsNUpum6ZOD3AjU0Z=qw@mail.gmail.com
Whole thread Raw
In response to Re: psql - factor out echo code  (Fabien COELHO <coelho@cri.ensmp.fr>)
Responses Re: psql - factor out echo code
List pgsql-hackers
On Sat, Jul 3, 2021 at 3:07 AM Fabien COELHO <coelho@cri.ensmp.fr> wrote:
>
>
> >  "-- # <whatever> QUERY\n%s\n\n"
>
> Attached an attempt along those lines. I found another duplicate of the
> ascii-art printing in another function.
>
> Completion queries seems to be out of the echo/echo hidden feature.
>
> Incredible, there is a (small) impact on regression tests for the \gexec
> case. All other changes have no impact, because they are not tested:-(

I am changing the status to "Needs review" as the review is not
completed for this patch and also there are some tests failing, that
need to be fixed:
test test_extdepend               ... FAILED       50 ms

Regards,
Vignesh



pgsql-hackers by date:

Previous
From: John Naylor
Date:
Subject: Re: Reduce lock level for ALTER TABLE ... ADD CHECK .. NOT VALID
Next
From: Tomas Vondra
Date:
Subject: Re: proposal: possibility to read dumped table's name from file