Re: Option to dump foreign data in pg_dump - Mailing list pgsql-hackers

From Surafel Temesgen
Subject Re: Option to dump foreign data in pg_dump
Date
Msg-id CALAY4q9P=PmuHv8bA+s22RZUPj1RJAhU3qLXnjM7oT5iFZcfnA@mail.gmail.com
Whole thread Raw
In response to Re: Option to dump foreign data in pg_dump  (Luis Carril <luis.carril@swarm64.com>)
Responses Re: Option to dump foreign data in pg_dump
List pgsql-hackers


On Fri, Sep 20, 2019 at 6:20 PM Luis Carril <luis.carril@swarm64.com> wrote:
Hello,
   thanks for the comments!

* + if (tdinfo->filtercond || tbinfo->relkind == RELKIND_FOREIGN_TABLE)

filter condition is not implemented completely yet so the logic only work on foreign table so I think its better to handle it separately

Note that there is another if condition that actually applies the the filtercondition if provided, also for a we need to do a COPY SELECT instead of a COPY TO

but we can't supplied where clause in pg_dump yet so filtercondtion is always NULL and the logic became true only on foreign table.

* I don’t understand the need for changing SELECT query .we can use the same SELECT query syntax for both regular table and foreign table

To which query do you refer? In the patch there are three queries: 1 retrieves foreign servers, another is the SELECT in the COPY that now it applies in case of a filter condition of a foreign table, and a third that retrieves the oid of a given foreign server.


SELECT on COPY  

regards
Surafel

pgsql-hackers by date:

Previous
From: Kyotaro Horiguchi
Date:
Subject: Re: PATCH: standby crashed when replay block which truncated instandby but failed to truncate in master node
Next
From: Kyotaro Horiguchi
Date:
Subject: Re: Cache lookup errors with functions manipulation objectaddresses