Re: pg_dump multi VALUES INSERT - Mailing list pgsql-hackers

From Surafel Temesgen
Subject Re: pg_dump multi VALUES INSERT
Date
Msg-id CALAY4q87JrXD6kVETRb87QbRPzxZ_UU+nzpBmgc2L41TRG_sAg@mail.gmail.com
Whole thread Raw
In response to Re: pg_dump multi VALUES INSERT  (David Rowley <david.rowley@2ndquadrant.com>)
Responses Re: pg_dump multi VALUES INSERT  (David Rowley <david.rowley@2ndquadrant.com>)
List pgsql-hackers
Hi,
Thank you for looking at it
On Mon, Dec 31, 2018 at 12:38 PM David Rowley <david.rowley@2ndquadrant.com> wrote:
Just looking at the v5 patch, it seems not to handle 0 column tables correctly.

For example:

# create table t();
# insert into t default values;
# insert into t default values;

$ pg_dump --table t --inserts --insert-multi=100 postgres > dump.sql

# \i dump.sql
[...]
INSERT 0 1
psql:dump.sql:35: ERROR:  syntax error at or near ")"
LINE 1: );
        ^

The attach patch contain a fix for it
Regards
Surafel
 
Attachment

pgsql-hackers by date:

Previous
From: Alexander Kukushkin
Date:
Subject: Re: Connection slots reserved for replication
Next
From: Stephen Frost
Date:
Subject: Re: [HACKERS] REINDEX CONCURRENTLY 2.0