Re: WIP: System Versioned Temporal Table - Mailing list pgsql-hackers

From Surafel Temesgen
Subject Re: WIP: System Versioned Temporal Table
Date
Msg-id CALAY4q-UhYNK-RaiNQ7ZzU64-CYHBXYXvMrqe6vumFaF0o4Yew@mail.gmail.com
Whole thread Raw
In response to Re: WIP: System Versioned Temporal Table  (Simon Riggs <simon.riggs@enterprisedb.com>)
Responses Re: WIP: System Versioned Temporal Table
Re: WIP: System Versioned Temporal Table
List pgsql-hackers
Hi Simon,
Thank you for all the work you does

On Mon, Jan 11, 2021 at 5:02 PM Simon Riggs <simon.riggs@enterprisedb.com> wrote:


* Anomalies around use of CURRENT_TIMESTAMP are not discussed or resolved.
Probably need to add a test that end_timestamp > start_timestamp or ERROR,
which effectively enforces serializability.



This scenario doesn't happen. There are no possibility of a record being deleted or updated before inserting
 
* No discussion, comments or tests around freezing and whether that
causes issues here


This feature introduced no new issue regarding freezing. Adding
the doc about the table size growth because of a retention of old record seems
enough for me
 

* ALTER TABLE needs some work, it's a bit klugey at the moment and
needs extra tests.
Should refuse DROP COLUMN on a system time column, but currently doesn't

* UPDATE foo SET start_timestamp = DEFAULT should fail but currently doesn't


okay i will fix it
 
regards
Surafel

pgsql-hackers by date:

Previous
From: Magnus Hagander
Date:
Subject: Re: vacuum_cost_page_miss default value and modern hardware
Next
From: Surafel Temesgen
Date:
Subject: Re: WIP: System Versioned Temporal Table