Re: extension patch of CREATE OR REPLACE TRIGGER - Mailing list pgsql-hackers

I don't test your patch fully yet but here are same comment.

There are same white space issue like here

-  bool is_internal)
+  bool is_internal,
+  Oid existing_constraint_oid)

in a few place

+ // trigoid = HeapTupleGetOid(tuple); // raw code

please remove this line if you don't use it.

+ if(!existing_constraint_oid){
+ conOid = GetNewOidWithIndex(conDesc, ConstraintOidIndexId,
+ Anum_pg_constraint_oid);
+ values[Anum_pg_constraint_oid - 1] = ObjectIdGetDatum(conOid);
+ }

incorrect bracing style here and its appear in a few other places too

and it seems to me that the change in regression test is

huge can you reduce it?

regards

Surafel