Re: [DOCS] INSERT documentation - Mailing list pgsql-docs

From Marko Tiikkaja
Subject Re: [DOCS] INSERT documentation
Date
Msg-id CAL9smLCSvja9czoPtekezq-s4ugeG6DmWkMfU4FLM4Hf13xz0w@mail.gmail.com
Whole thread Raw
In response to [DOCS] INSERT documentation  (nat@makarevitch.org)
List pgsql-docs
On Wed, Oct 11, 2017 at 5:34 PM, <nat@makarevitch.org> wrote:
The following documentation comment has been logged on the website:

Page: https://www.postgresql.org/docs/10/static/sql-insert.html
Description:

Hi,

In the &quot;ON CONFLICT Clause&quot; section of the official INSERT documentation (
https://www.postgresql.org/docs/10/static/sql-insert.html#sql-on-conflict )
you can read:
&quot;index_column_name
The name of a table_name column.&quot;
This seems misleading to me as multiple columns may be named there.  The
second sentence of this section&#39;s second paragraph is clear (&quot;When
performing inference, it consists of one or more index_column_name&quot;) but a
reader jumping to the detail may miss this information.

Suggestion: s/The name of a table_name column/The name of at least one
column/

But index_column_name *is*the name of only a single column.  The syntax is (irrelevant parts omitted):

   ( index_column_name [, ...] )

which means "opening parenthesis, index_column_name followed by zero or more index_column_name, and a closing parenthesis".  The documentation seems correct to me.


.m

pgsql-docs by date:

Previous
From: bunyaminsevgin@gmail.com
Date:
Subject: [DOCS] Full Stack Developer
Next
From: Tom Lane
Date:
Subject: Re: [DOCS] version 10 release note mistype in release-10.sgml