Re: fallocate / posix_fallocate for new WAL file creation (etc...) - Mailing list pgsql-hackers

From Jon Nelson
Subject Re: fallocate / posix_fallocate for new WAL file creation (etc...)
Date
Msg-id CAKuK5J14rxgd259KK6Xd0HmR+90o3hpi++NFZfh5n84rrGZ5_g@mail.gmail.com
Whole thread Raw
In response to Re: fallocate / posix_fallocate for new WAL file creation (etc...)  (Alvaro Herrera <alvherre@2ndquadrant.com>)
Responses Re: fallocate / posix_fallocate for new WAL file creation (etc...)  (Jon Nelson <jnelson+pgsql@jamponi.net>)
List pgsql-hackers
On Wed, May 15, 2013 at 10:17 PM, Alvaro Herrera
<alvherre@2ndquadrant.com> wrote:
> Jon Nelson escribió:
>> On Wed, May 15, 2013 at 4:46 PM, Jon Nelson <jnelson+pgsql@jamponi.net> wrote:
>
>> > That's true. I originally wrote the patch using fallocate(2). What
>> > would be appropriate here? Should I switch on the return value and the
>> > six (6) or so relevant error codes?
>>
>> I addressed this, hopefully in a reasonable way.
>
> Would it work to just assign the value you got from posix_fallocate (if
> nonzero) to errno and then use %m in the errmsg() call in ereport()?

That strikes me as a better way. I'll work something up soon.
Thanks!

--
Jon



pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: plperl segfault in plperl_trusted_init() on kfreebsd
Next
From: Amit Langote
Date:
Subject: Re: Logging of PAM Authentication Failure