Postgres Pro
Downloads
Home   >   mailing lists

Fix GetWALAvailability function code comments for WALAVAIL_REMOVED return value - Mailing list pgsql-hackers

From sirisha chamarthi
Subject Fix GetWALAvailability function code comments for WALAVAIL_REMOVED return value
Date
Msg-id CAKrAKeXt-=bgm=d+EDmcC9kWoikp8kbVb3LH0K3K+AGGsykpHQ@mail.gmail.com
Whole thread Raw
Responses Re: Fix GetWALAvailability function code comments for WALAVAIL_REMOVED return value  (Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>)
List pgsql-hackers
Tree view
Hi Hackers,

The current code comment says that the replication stream on a slot with the given targetLSN can't continue after a restart but even without a restart the stream cannot continue. The slot is invalidated and the walsender process is terminated by the checkpoint process. Attaching a small patch to fix the comment.

2022-10-19 06:26:22.387 UTC [144482] STATEMENT:  START_REPLICATION SLOT "s2" LOGICAL 0/0
2022-10-19 06:27:41.998 UTC [2553755] LOG:  checkpoint starting: time
2022-10-19 06:28:04.974 UTC [2553755] LOG:  terminating process 144482 to release replication slot "s2"
2022-10-19 06:28:04.974 UTC [144482] FATAL:  terminating connection due to administrator command
2022-10-19 06:28:04.974 UTC [144482] CONTEXT:  slot "s2", output plugin "test_decoding", in the change callback, associated LSN 0/1E23AB68
2022-10-19 06:28:04.974 UTC [144482] STATEMENT:  START_REPLICATION SLOT "s2" LOGICAL 0/0

Thanks,
Sirisha
Attachment

pgsql-hackers by date:

Previous
From: Bharath Rupireddy
Date:
Subject: Re: Avoid memory leaks during base backups
Next
From: Bharath Rupireddy
Date:
Subject: Re: Fix GetWALAvailability function code comments for WALAVAIL_REMOVED return value