Re: Adding support for SSLKEYLOGFILE in the frontend - Mailing list pgsql-hackers

From Abhishek Chanda
Subject Re: Adding support for SSLKEYLOGFILE in the frontend
Date
Msg-id CAKiP-K_0HV+Vte1CqGMtJErt7yB-1hwu9wF4+wef0QeSCqhO4Q@mail.gmail.com
Whole thread Raw
In response to Re: Adding support for SSLKEYLOGFILE in the frontend  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: Adding support for SSLKEYLOGFILE in the frontend
List pgsql-hackers
Hi all,

Please find attached a new version of this patch. I rebased on master,
added better error reporting and skipped the permissions check on
windows. Please let me know if this needs any changes. I tested this
locally using meson running all TAP tests.

Thanks

On Fri, Jan 10, 2025 at 5:16 PM Abhishek Chanda <abhishek.becs@gmail.com> wrote:
>
> Thanks, Daniel. Here is an updated patch with all previous changes,
> added a simple connection test and another check to make sure file
> mode is correct, and the env var fix. Please let me know if anything
> needs to be changed. I tested this locally using meson running all TAP
> tests, and also manually.
>
> Thanks
> Abhishek
>
> On Fri, Jan 10, 2025 at 9:29 AM Daniel Gustafsson <daniel@yesql.se> wrote:
> >
> > > On 10 Jan 2025, at 04:59, Abhishek Chanda <abhishek.becs@gmail.com> wrote:
> >
> > Thanks for the new version.
> >
> > +       {"sslkeylogfile", "SSLKEYLOGFILE",
> > The env var should be PGSSLKEYLOGFILE with the PG prefix.
> >
> > > 3. Added docs and tests
> >
> > There is no test in the attached patch, did you write one but forgot to git add
> > it before committing locally?
> >
> > --
> > Daniel Gustafsson
> >
>
>
> --
> Thanks and regards
> Abhishek Chanda



--
Thanks and regards
Abhishek Chanda

Attachment

pgsql-hackers by date:

Previous
From: Ajin Cherian
Date:
Subject: Re: Proposal: Filter irrelevant change before reassemble transactions during logical decoding
Next
From: "Hayato Kuroda (Fujitsu)"
Date:
Subject: RE: Proposal: Filter irrelevant change before reassemble transactions during logical decoding