Home > mailing lists

as per commit 643a1a61985bef2590496, move create/open dir code to function using switch case of pg_backup_directory.c file also - Mailing list pgsql-hackers

From	Mahendra Singh Thalor
Subject	as per commit 643a1a61985bef2590496, move create/open dir code to function using switch case of pg_backup_directory.c file also
Date	April 7 15:25:54
Msg-id	CAKYtNApO30tdtRfe6rJK59pj6Mr=xW8hQELJ8+Vz95goHk3pQg@mail.gmail.com Whole thread Raw
Responses	Re: as per commit 643a1a61985bef2590496, move create/open dir code to function using switch case of pg_backup_directory.c file also
List	pgsql-hackers

Hi,

In commit 643a1a61985bef2590496, we did some cleanup and we replaced if-else with switch case.

Basically, we made a function to open a directory in pg_dumpall. In pg_backup_directory.c file also, we are opening a directory with if-else.

Here, I am attaching a patch which makes both the files similar.

We can move this similar function into one common file also but as of now, I made a static function same as pg_dumpall.c.

Thanks and Regards
Mahendra Singh Thalor
EnterpriseDB: http://www.enterprisedb.com

From: Jim Jones
Date: 07 April, 15:25:52
Subject: Re: [PATCH] Add CANONICAL option to xmlserialize

From: Álvaro Herrera
Date: 07 April, 15:30:59
Subject: Re: Restrict publishing of partitioned table with a foreign table as partition