Re: Support reset of Shared objects statistics in "pg_stat_reset" function - Mailing list pgsql-hackers

From Mahendra Singh Thalor
Subject Re: Support reset of Shared objects statistics in "pg_stat_reset" function
Date
Msg-id CAKYtNAp4Zia3buW4oHwf1JgrgGexMhwxkchj4+xbS-pSfnDNxQ@mail.gmail.com
Whole thread Raw
In response to Re: Support reset of Shared objects statistics in "pg_stat_reset" function  (Sadhuprasad Patro <b.sadhu@gmail.com>)
Responses Re: Support reset of Shared objects statistics in "pg_stat_reset" function
List pgsql-hackers
On Sun, 22 Aug 2021 at 22:53, Sadhuprasad Patro <b.sadhu@gmail.com> wrote:
>
> > On 2021/08/20 11:07, Mahendra Singh Thalor wrote:
> > > 1)
> > >           Resets statistics for a single table or index in the current database
> > > -        to zero.
> > > +        to zero. The input can be a shared table also
> > >
> > > I think, above comment should be modified. Maybe, we can modify it as "If input is a shared oid(table or index or toast), then resets statistics for a single shared entry to zero.
> >
> > I'm not sure if ordinary users can understand what "shared oid" means. Instead,
> > what about "Resets statistics for a single relation in the current database or
> > shared across all databases in the cluster to zero."?
> >
>
> Thank you for the review here. As per the comments, attached the
> latest patch here...
>

Thanks Sadhu for the updated patch.

Patch looks good to me and I don't have any more comments.

I marked this patch as 'ready for committer'.

--
Thanks and Regards
Mahendra Singh Thalor
EnterpriseDB: http://www.enterprisedb.com

pgsql-hackers by date:

Previous
From: Amit Langote
Date:
Subject: Re: Allow batched insert during cross-partition updates
Next
From: Greg Nancarrow
Date:
Subject: Re: Parallel scan with SubTransGetTopmostTransaction assert coredump