Home > mailing lists

Re: Fix the miss consideration of tuple_fraction during add_paths_to_append_rel - Mailing list pgsql-hackers

From	Andy Fan
Subject	Re: Fix the miss consideration of tuple_fraction during add_paths_to_append_rel
Date	April 11, 2023 20:45:10
Msg-id	CAKU4AWrwRbtO4+a+WhLG-2TG3hk-oFNTdt5p=1GYp+4jk+-PeA@mail.gmail.com Whole thread Raw
In response to	Re: Fix the miss consideration of tuple_fraction during add_paths_to_append_rel (Zhang Mingli <zmlpostgres@gmail.com>)
List	pgsql-hackers

Tree view

On Mon, Apr 10, 2023 at 9:56 PM Zhang Mingli <zmlpostgres@gmail.com> wrote:

There is spare indent at else if.

- if (childrel->pathlist != NIL &&
+ if (cheapest_startup_path && cheapest_startup_path->param_info == NULL)
+ accumulate_append_subpath(cheapest_startup_path,
+   &subpaths, NULL);
+ else if (childrel->pathlist != NIL &&
childrel->cheapest_total_path->param_info == NULL)
accumulate_append_subpath(childrel->cheapest_total_path,
  &subpaths, NULL);

Could we also consider tuple_fraction in partial_pathlist for  parallel append?