Re: A minor adjustment to get_cheapest_path_for_pathkeys - Mailing list pgsql-hackers

From Andy Fan
Subject Re: A minor adjustment to get_cheapest_path_for_pathkeys
Date
Msg-id CAKU4AWrnX6rjPkysb+Cfdd8HdKPFEg_-9z5pdsqY3uwCRYxM1g@mail.gmail.com
Whole thread Raw
In response to Re: A minor adjustment to get_cheapest_path_for_pathkeys  (Andy Fan <zhihui.fan1213@gmail.com>)
List pgsql-hackers


I guess the *valuable* sometimes means the effort we pay is greater
than the benefit we get,  As for this patch,  the benefit is not huge (it 
is possible the compiler already does that). and the most effort we pay
should be committer's attention, who needs to grab the patch, write the
correct  commit and credit to the author and push it.  I'm not sure if 
Aleksander is worrying that this kind of patch will grab too much of 
the committer's attention and I do see there are lots of patches like 
this.
 
I forget to mention that the past contribution of the author should be a 
factor as well.  Like Richard has provided lots of performance improvement,
bug fix, code reviews, so I believe more attention from committers should
be a reasonable request.  

--
Best Regards
Andy Fan

pgsql-hackers by date:

Previous
From: Andy Fan
Date:
Subject: Re: Extract numeric filed in JSONB more effectively
Next
From: Quan Zongliang
Date:
Subject: Re: Improving the heapgetpage function improves performance in common scenarios