Home > mailing lists

Re: [PATCH] Keeps tracking the uniqueness with UniqueKey - Mailing list pgsql-hackers

From	Andy Fan
Subject	Re: [PATCH] Keeps tracking the uniqueness with UniqueKey
Date	June 29, 2020 12:59:21
Msg-id	CAKU4AWrT=o0dEmdFCH3W6B=BeUS1=OU5N86FfAmKFUahSP48SA@mail.gmail.com Whole thread Raw
In response to	Re: [PATCH] Keeps tracking the uniqueness with UniqueKey (Dmitry Dolgov <9erthalion6@gmail.com>)
Responses	Re: [PATCH] Keeps tracking the uniqueness with UniqueKey
List	pgsql-hackers

I just did another self-review about this patch and took some suggestions based

on the discussion above. The attached is the v9 version. When you check the

uniquekey patch, README.uniquekey should be a good place to start with.

Main changes in v9 includes:

1. called populate_baserel_uniquekeys after check_index_predicates.

2. removed the UniqueKey->onerow flag since we can tell it by exprs == NIL.

3. expression index code improvement.

4. code & comments refactoring.

As for the Index Skip Scan, I still have not merged the changes in the Index

Skip Scan patch[1]. We may need some addition for that, but probably not

need to modify the existing code. After we can finalize it, we can add it in

that patch. I will keep a close eye on it as well.

Best Regards

Andy Fan

From: Peter Eisentraut
Date: 29 June 2020, 12:58:11
Subject: Re: update substring pattern matching syntax

From: Bharath Rupireddy
Date: 29 June 2020, 13:02:00
Subject: Re: estimation problems for DISTINCT ON with FDW