Re: [PATCH] Keeps tracking the uniqueness with UniqueKey - Mailing list pgsql-hackers

From Andy Fan
Subject Re: [PATCH] Keeps tracking the uniqueness with UniqueKey
Date
Msg-id CAKU4AWoN8fJrZ=8b_6iCWF6rvxn_bx46D6Q_gRucJYOhRvSdKQ@mail.gmail.com
Whole thread Raw
In response to Re: [PATCH] Keeps tracking the uniqueness with UniqueKey  (Michael Paquier <michael@paquier.xyz>)
Responses Re: [PATCH] Keeps tracking the uniqueness with UniqueKey  (Dmitry Dolgov <9erthalion6@gmail.com>)
List pgsql-hackers


On Mon, Sep 7, 2020 at 3:22 PM Michael Paquier <michael@paquier.xyz> wrote:
On Tue, Aug 04, 2020 at 06:59:50AM +0800, Andy Fan wrote:
> You are correct, I would include this in the next version patch, Thank you
> for this checking!

Regression tests are failing with this patch set applied.  The CF bot
says so, and I can reproduce that locally as well.  Could you look at
that please?  I have switched the patch to "waiting on author".
--
Michael
 
Thank you Michael for checking it, I can reproduce the same locally after 
rebasing to the latest master. The attached v11 has fixed it and includes 
the fix Floris found.

The status of this patch is we are still in discussion about which data type should
UniqueKey->expr use.  Both David [1] and I [2] shared some thinking about
EquivalenceClasses, but neither of us have decided on it. So I still didn't change
anything about that  now.   I can change it once we have decided on it.

--
Best Regards
Andy Fan
Attachment

pgsql-hackers by date:

Previous
From: Tomas Vondra
Date:
Subject: Re: WIP: WAL prefetch (another approach)
Next
From: Yugo NAGATA
Date:
Subject: Re: Implementing Incremental View Maintenance