Re: Patch: make behavior of all versions of the "isinf" function be similar - Mailing list pgsql-hackers

From Vitaly Burovoy
Subject Re: Patch: make behavior of all versions of the "isinf" function be similar
Date
Msg-id CAKOSWN=Gf4prZO54FxcjYTuXPXO6t32NOXo-E-NU9KCf2u236g@mail.gmail.com
Whole thread Raw
In response to Re: Patch: make behavior of all versions of the "isinf" function be similar  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: Patch: make behavior of all versions of the "isinf" function be similar
List pgsql-hackers
On 1/31/16, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> 2. POSIX:2008 only requires that "The isinf() macro shall return a
> non-zero value if and only if its argument has an infinite value."
> Therefore, any assumption about the sign of the result is wrong anyway,
> and any patch that depends on it will be rejected, regardless of what
> isinf.c does.  Or else, if you can convince us that such an assumption
> is really valuable, we'd need isinf.c more not less so that we can
> replace isinf() on platforms where it doesn't meet the stronger spec.
>
>             regards, tom lane

Ok, then I'll use "is_infinite" from "float.c".
But why functions' (in "src/port/isinf.c") behavior are different? It
is a bit confusing…
--
Best regards,
Vitaly Burovoy



pgsql-hackers by date:

Previous
From: Andres Freund
Date:
Subject: Re: Template for commit messages
Next
From: Fujii Masao
Date:
Subject: Re: Several problems in tab-completions for SET/RESET