Re: [pgAdmin4[RM#3935] Grant wizard fails to list down functions - Mailing list pgadmin-hackers

From Murtuza Zabuawala
Subject Re: [pgAdmin4[RM#3935] Grant wizard fails to list down functions
Date
Msg-id CAKKotZTMNh2r22+_esMWoOYbiXhs3bU0R5oc9oaCPNxs4S8Rkw@mail.gmail.com
Whole thread Raw
In response to Re: [pgAdmin4[RM#3935] Grant wizard fails to list down functions  (Akshay Joshi <akshay.joshi@enterprisedb.com>)
Responses Re: [pgAdmin4[RM#3935] Grant wizard fails to list down functions  (Akshay Joshi <akshay.joshi@enterprisedb.com>)
List pgadmin-hackers
Hi,

On Mon, Jan 28, 2019 at 4:38 PM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:
Hi Murtuza

Here are my review comments:
  • Exact error should be logged in the log file and on GUI we should show message like "Unable to fetch <function/table> object".
Fixed 
  • Message should be shown in the status bar.
Fixed 
  • If there is an error to fetch one kind of object, we should show other objects.
Fixed.


Please find the updated patch.


Regards,
Murtuza 

On Mon, Jan 28, 2019 at 2:49 PM Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:
Hi,

PFA minor patch, To display an error on UI when there is a backend error for the grant wizard request.
Please review.

--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company



On Mon, Jan 28, 2019 at 12:48 PM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:
Thanks patch applied.

On Mon, Jan 28, 2019 at 12:01 PM Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:
Hi,

PFA patch to fix the issue where EPAS DB instance running with no-redwood-compat mode fails to list down functions objects in grant wizard due to 'char' -> 'int' type cast error.


--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company



--
Akshay Joshi
Sr. Software Architect


Phone: +91 20-3058-9517
Mobile: +91 976-788-8246


--
Akshay Joshi
Sr. Software Architect


Phone: +91 20-3058-9517
Mobile: +91 976-788-8246
Attachment

pgadmin-hackers by date:

Previous
From: Akshay Joshi
Date:
Subject: pgAdmin 4 commit: Fixed debugger issue for procedure inside packagefor
Next
From: Khushboo Vashi
Date:
Subject: Re: [pgAdmin4][Patch]: RM - 3051 - ables > Properties > Columns tab is slow on tables with a lot of fields