Re: [pgadmin-hackers] PATCH: To fix the issue in Database node (pgAdmin4) - Mailing list pgadmin-hackers

From Murtuza Zabuawala
Subject Re: [pgadmin-hackers] PATCH: To fix the issue in Database node (pgAdmin4)
Date
Msg-id CAKKotZTG2xLJ8e8StAgMZ13fKiDxnnLfQwc+mjSfq2vAst9eLg@mail.gmail.com
Whole thread Raw
In response to Re: [pgadmin-hackers] PATCH: To fix the issue in Database node (pgAdmin4)  (Dave Page <dpage@pgadmin.org>)
Responses Re: [pgadmin-hackers] PATCH: To fix the issue in Database node (pgAdmin4)
List pgadmin-hackers
Hi Dave,

PFA updated patch, issue was conn.release(did=did) was removing all connection for same database from connection manager.
We have now created new connection for offline updates using "conn_id" parameter instead of did.

Please review.   

--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


On Mon, Jan 30, 2017 at 8:03 PM, Dave Page <dpage@pgadmin.org> wrote:
Hi

On Mon, Jan 30, 2017 at 5:31 AM, Murtuza Zabuawala
<murtuza.zabuawala@enterprisedb.com> wrote:
> Hi Dave,
>
> Please find updated patch, Tested against maintenance database as well.

I can change parameters on the maintenance DB now, but it still
crashes if I try to change the comment. Both operations on other
databases seem to work OK.

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Attachment

pgadmin-hackers by date:

Previous
From: Fahar Abbas
Date:
Subject: Re: [pgadmin-hackers][Patch] Show databases for Greenplum
Next
From: Dave Page
Date:
Subject: [pgadmin-hackers] pgAdmin 4 commit: Properly handle setting comments and other optionson