Postgres Pro
Downloads
Home   >   mailing lists

Re: [pgAdmin4][RM#3002] To fix the indentation issue in query tool editor - Mailing list pgadmin-hackers

From Murtuza Zabuawala
Subject Re: [pgAdmin4][RM#3002] To fix the indentation issue in query tool editor
Date
Msg-id CAKKotZSHX0ytBFQE2nu9DR_SpV0h_UK1Hirnph7eHCXD93cZCQ@mail.gmail.com
Whole thread Raw
In response to Re: [pgAdmin4][RM#3002] To fix the indentation issue in query tool editor  (Joao De Almeida Pereira <jdealmeidapereira@pivotal.io>)
Responses Re: [pgAdmin4][RM#3002] To fix the indentation issue in query tool editor  (Dave Page <dpage@pgadmin.org>)
List pgadmin-hackers
Tree view
Thank you for testing it Joao.

--
Regards,
Murtuza

On Tue, Feb 27, 2018 at 8:29 PM, Joao De Almeida Pereira <jdealmeidapereira@pivotal.io> wrote:
Hello Murtuza,

The patch looks good, and solves the problem. Run the patch on our CI and everything is green.

Thanks
Joao

On Tue, Feb 27, 2018 at 8:11 AM Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:
Hi,

PFA patch to fix the issue where Tab key was not working as expected in query tool editor.

Steps to reproduce:
1) Type any multiline sql/text.
2) select the complete sql by pressing Ctrl+A.
3) Press Tab key multiple times, you will see the problem in code indentation.

Please review.

--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


pgadmin-hackers by date:

Previous
From: Joao De Almeida Pereira
Date:
Subject: Re: [pgAdmin4][RM#3002] To fix the indentation issue in query tool editor
Next
From: Murtuza Zabuawala
Date:
Subject: [pgAdmin4][RM#3156] Fix PEP-8 issues