Re: PATCH: Adding more confirmations in query tool (pgAdmin4) - Mailing list pgadmin-hackers

From Murtuza Zabuawala
Subject Re: PATCH: Adding more confirmations in query tool (pgAdmin4)
Date
Msg-id CAKKotZRszTNg8-_eB=km-ESdpwwt20JKr4V68s4WZQwnwHJPWw@mail.gmail.com
Whole thread Raw
In response to Re: PATCH: Adding more confirmations in query tool (pgAdmin4)  (Dave Page <dpage@pgadmin.org>)
Responses Re: PATCH: Adding more confirmations in query tool (pgAdmin4)  (Dave Page <dpage@pgadmin.org>)
List pgadmin-hackers
Hi Dave,

Please find updated patch.
Please review.


--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


On Wed, Sep 7, 2016 at 7:30 PM, Dave Page <dpage@pgadmin.org> wrote:
I think it's better to warn them as early as possible, as we do in
pgAdmin 3 (actually, there we just prompt them to save the changes,
but I think either is fine).

On Wed, Sep 7, 2016 at 2:04 PM, Murtuza Zabuawala
<murtuza.zabuawala@enterprisedb.com> wrote:
> Sure I'll do it, But I thought like let user traverse through file manager
> (he may or may not select any file to load) and warn only if he/she try to
> load file.
>
>
> --
> Regards,
> Murtuza Zabuawala
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
> On Wed, Sep 7, 2016 at 6:30 PM, Dave Page <dpage@pgadmin.org> wrote:
>>
>> Hi
>>
>> On Wed, Sep 7, 2016 at 10:38 AM, Murtuza Zabuawala
>> <murtuza.zabuawala@enterprisedb.com> wrote:
>> > Hi,
>> >
>> > PFA patch to add more confirmations in query tool before taking any
>> > actions
>> > which might cause lose changes,
>> > - Clearing editor
>> > - Clearing history
>> > - Load file data
>> >  RM#1666
>> >
>> > Please review.
>>
>> Can you tweak it so that the confirmation is requested as soon as the
>> open file button is clicked, rather than when a file is selected
>> please? I think that's a little more 'normal' :-).
>>
>> Thanks!
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>
>



--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Attachment

pgadmin-hackers by date:

Previous
From: Dave Page
Date:
Subject: Re: [pgAdmin4][Patch]: RM1581 - When switching between query tabs, the selected tab is not ready to run a query
Next
From: Dave Page
Date:
Subject: pgAdmin 4 commit: Confirm loss of changes with the user before clearing